Hyperblock processor #4
Conversation
| return err | ||
| } | ||
|
|
||
| if outportBlock == nil || outportBlock.BlockData == nil { |
There was a problem hiding this comment.
can outportBlock ever be nil? thinking of removing the check since it might be redundant
There was a problem hiding this comment.
yes, if marshalledData is nil, the marshaller will return nil on Unmarshall
There was a problem hiding this comment.
right. missed that, thanks for the clarification.
go.mod
Outdated
| github.com/multiversx/mx-chain-communication-go v1.0.12 | ||
| github.com/multiversx/mx-chain-core-go v1.2.18 | ||
| github.com/multiversx/mx-chain-logger-go v1.0.13 | ||
| github.com/multiversx/mx-chain-communication-go v1.0.13-0.20240126121117-627adccf10ad |
There was a problem hiding this comment.
are the changes here needed?
There was a problem hiding this comment.
latest storage version does not work with core 1.2.18, we might need to have a new storage version
There was a problem hiding this comment.
in the meantime, we have storage v1.0.15 which works well with latest core version; updated storage version
| ) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| // TODO: move cache to config |
There was a problem hiding this comment.
will you move this to config in the next task?
There was a problem hiding this comment.
yes, this is already done on next PR
process/dataProcessor.go
Outdated
| blocksPool BlocksPool, | ||
| dataAggregator DataAggregator, | ||
| ) (DataProcessor, error) { | ||
| if publisher == nil { |
There was a problem hiding this comment.
any reason not to include IsInterfaceNil in the interface and then check here with check.ifnil?
| } | ||
|
|
||
| // Close will close the internal writer | ||
| func (dp *dataProcessor) Close() error { |
There was a problem hiding this comment.
close will need to persist also block pool data.
can be done on the next PR.
process/dataProcessor_test.go
Outdated
| func TestDataProcessor_ProcessPayload(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| t.Run("nil outport block, should return error", func(t *testing.T) { |
There was a problem hiding this comment.
change description to nil outport block data... instead of nil outport block...?
| // notarized shards data | ||
| func (da *dataAggregator) ProcessHyperBlock(outportBlock *outport.OutportBlock) (*data.HyperOutportBlock, error) { | ||
| hyperOutportBlock := &data.HyperOutportBlock{} | ||
| hyperOutportBlock.MetaOutportBlock = outportBlock |
There was a problem hiding this comment.
maybe some check that the received outport block is indeed a metablock, e.g. check the ShardID?
Added hyper outport block processor components: