-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Unstake SC helper functions updates #1007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
psorinionut
commented
Feb 21, 2025
- Added setFeesBurnPercentage helper function
- Added a non zero burn penalty check
Coverage SummaryTotals
FilesExpand
|
Contract comparison - from 2fb3b5a to 1814b7d
|
fn set_fees_burn_percentage(&self, fees_burn_percentage: u64) { | ||
require!( | ||
fees_burn_percentage <= MAX_PENALTY_PERCENTAGE, | ||
"Invalid percentage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this require message would be bit confusing for an user, maybe write something more verbose, such as:
"Fees burn percentage exceeds the maximum penalty percentage".
Other than that, looks good to me!
andreiblt1304
previously approved these changes
Feb 21, 2025
andreiblt1304
approved these changes
Feb 21, 2025
sasurobert
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.