remove exit amount parameter from farms #3593
reviewdog [clippy] report
reported by reviewdog 🐶
Findings (2)
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|35 col 28| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|35 col 28| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
Filtered Findings (14)
dex/farm/src/lib.rs|125 col 83| warning: redundant clone
--> dex/farm/src/lib.rs:125:83
|
125 | let claim_rewards_result = self.claim_rewards::<Wrapper>(orig_caller.clone());
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/src/lib.rs:125:72
|
125 | let claim_rewards_result = self.claim_rewards::<Wrapper>(orig_caller.clone());
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm-with-locked-rewards/src/lib.rs|168 col 27| warning: redundant clone
--> dex/farm-with-locked-rewards/src/lib.rs:168:27
|
168 | rewards.amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm-with-locked-rewards/src/lib.rs:168:13
|
168 | rewards.amount.clone(),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|49 col 24| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:49:24
|
49 | orig_caller.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:49:13
|
49 | orig_caller.clone(),
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|52 col 54| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:52:54
|
52 | exit_attributes.staking_farm_token_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:52:13
|
52 | exit_attributes.staking_farm_token_amount.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
locked-asset/proxy_dex/src/proxy_farm.rs|169 col 17| warning: redundant clone
--> locked-asset/proxy_dex/src/proxy_farm.rs:169:17
|
169 | .clone()
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> locked-asset/proxy_dex/src/proxy_farm.rs:168:13
|
168 | / full_wrapped_farm_attributes
169 | | .clone()
| |^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs|186 col 33| warning: redundant clone
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:33
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:18
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm/src/lib.rs|125 col 83| warning: redundant clone
--> dex/farm/src/lib.rs:125:83
|
125 | let claim_rewards_result = self.claim_rewards::<Wrapper>(orig_caller.clone());
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/src/lib.rs:125:72
|
125 | let claim_rewards_result = self.claim_rewards::<Wrapper>(orig_caller.clone());
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs|186 col 33| warning: redundant clone
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:33
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:18
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs|186 col 33| warning: redundant clone
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:33
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:18
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|49 col 24| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:49:24
|
49 | orig_caller.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:49:13
|
49 | orig_caller.clone(),
| ^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs|52 col 54| warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:52:54
|
52 | exit_attributes.staking_farm_token_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:52:13
|
52 | exit_attributes.staking_farm_token_amount.clone(),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs|186 col 33| warning: redundant clone
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:33
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm/tests/farm_setup/farm_rewards_distr_setup.rs:186:18
|
186 | &farm_out_amount.clone(),
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
dex/farm-with-locked-rewards/src/lib.rs|168 col 27| warning: redundant clone
--> dex/farm-with-locked-rewards/src/lib.rs:168:27
|
168 | rewards.amount.clone(),
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> dex/farm-with-locked-rewards/src/lib.rs:168:13
|
168 | rewards.amount.clone(),
| ^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
locked-asset/proxy_dex/src/proxy_farm.rs|169 col 17| warning: redundant clone
--> locked-asset/proxy_dex/src/proxy_farm.rs:169:17
|
169 | .clone()
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> locked-asset/proxy_dex/src/proxy_farm.rs:168:13
|
168 | / full_wrapped_farm_attributes
169 | | .clone()
| |^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)]
on by default
Annotations
Check warning on line 35 in farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs
github-actions / clippy
[clippy] farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs#L35
warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
Raw output
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28:w:warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
__END__
Check warning on line 35 in farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs
github-actions / clippy
[clippy] farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs#L35
warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
Raw output
farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28:w:warning: redundant clone
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:28
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^ help: remove this
|
note: this value is dropped without further use
--> farm-staking/farm-staking-proxy/src/proxy_actions/unstake.rs:35:13
|
35 | full_attributes.clone().into_part(&payment.amount);
| ^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: `#[warn(clippy::redundant_clone)]` on by default
__END__