Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SERVICES-2608] Update sdk-core package #1488

Merged
merged 5 commits into from
Sep 24, 2024

Conversation

mad2sm0key
Copy link
Contributor

@mad2sm0key mad2sm0key commented Sep 24, 2024

Reasoning

  • the service currently uses deprecated or legacy functionality from the sdk-core package

Proposed Changes

  • update sdk-core to latest version
  • fix failing unit tests

How to test

  • N/A

- update sdk-core to v13.6.3
- update sdk-native-auth-server to v1.0.19
- MultiESDTNFTTransfer/ESDTNFTTransfer for a single fungible becomes ESDTTransfer
- MultiESDTNFTTransfer for a single MetaESDT becomes ESDTNFTTransfer
- the length of the random part of a collection identifier needs to be exactly 6 characters (enforced in v13)
@mad2sm0key mad2sm0key marked this pull request as ready for review September 24, 2024 12:26
@mad2sm0key mad2sm0key changed the title [SERVICES-2608] Update sdk-core dependency [SERVICES-2608] Update sdk-core package Sep 24, 2024
cfaur09
cfaur09 previously approved these changes Sep 24, 2024
bogdan-rosianu
bogdan-rosianu previously approved these changes Sep 24, 2024
@mad2sm0key mad2sm0key dismissed stale reviews from bogdan-rosianu and cfaur09 via d13f8b4 September 24, 2024 13:24
@mad2sm0key mad2sm0key merged commit 4899b8c into feat/sdk-core-v13 Sep 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants