[MEX-527] Refactor pair filtering #1536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update PairFilteringService to work with pair models with the fields already populated (functional service) - update PairMetadataBuilder to use the functional filtering service - update pair methods (regular and filtered) in router service to use the builder - remove duplicate code in router service
| this.pairs.map((pair) => pair.address), | ||
| ); | ||
|
|
||
| this.pairs.forEach( |
There was a problem hiding this comment.
it wouldn't make a much difference here, but for a high number of iterations, forEach is the least efficient way of ranging:
claudiulataretu
requested changes
Dec 19, 2024
| this.filters, | ||
| this.pairsMetadata, | ||
| this.pairs, | ||
| ); | ||
| return this; |
There was a problem hiding this comment.
All these filters from PairsMetadataBuilder should return the actual filtered pairs, not an instance of the class
| this.pairsMetadata = pairsMetadata; | ||
| this.filters = filters; | ||
| this.filteringService = filteringService; | ||
| constructor(pairService: PairService, pairCompute: PairComputeService) { |
There was a problem hiding this comment.
I think we can inject all the services in the constructor and also inject the builder class where it is used
|
|
||
| pairsMetadata = await builder.build(); | ||
| let pairs = builder.build(); |
There was a problem hiding this comment.
I don't think we need it anymore after the changes on the filtering methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
PairFilteringServiceto work with pair models with the fields already populated (functional service)PairMetadataBuilderto use the functional filtering serviceHow to test