added transaction tracking #51
Conversation
| export interface TrackedTransactionsSliceType { | ||
| [sessionId: string]: { | ||
| transactions: SignedTransactionType[]; | ||
| status?: TransactionBatchStatusesEnum; |
There was a problem hiding this comment.
TransactionBatchStatusesEnum | TransactionServerStatusesEnum
| @@ -55,6 +56,19 @@ export class TransactionManager { | |||
| } | |||
| }; | |||
|
|
|||
| public track = async ( | |||
| signedTransactions: Transaction[], | |||
| options?: { enableToasts: boolean } | |||
There was a problem hiding this comment.
disableToasts boolean default undefined ?
There was a problem hiding this comment.
i change it to default {enableToasts:true}
|
|
||
| export async function checkTransactionStatus( | ||
| props: TransactionsTrackerType & { | ||
| shouldRefreshBalance?: boolean; | ||
| } | ||
| ) { | ||
| const { pendingSessions } = getPendingStoreTransactions(); | ||
| const { pendingTrackedSessions: pendingSessions } = |
There was a problem hiding this comment.
why not keep sessions, since we don't have any other sessions
| const recheckStatus = () => { | ||
| checkTransactionStatus({ | ||
| shouldRefreshBalance: isWebsocketCompleted, | ||
| getTransactionsByHash, | ||
| ...props | ||
| getTransactionsByHash: getTransactionsByHashes |
There was a problem hiding this comment.
strange name difference. & why not use it as a default in checkTransactionStatus and allow optional override
There was a problem hiding this comment.
removed it and used as default in checkTransactionStatus
| ) => { | ||
| getStore().setState(({ toasts: state }) => { | ||
| const toastId = | ||
| currentToastId || `custom-toast-${state.customToasts.length + 1}`; |
There was a problem hiding this comment.
add toast 0 --> custom-toast-1
add toast 1 --> custom-toast-2
delete toast 0
add toast --> custom-toast-2 => you will have duplicates of custom-toast-2
solution state.customToasts --> get last toast index and increase it by one
| type: ToastsEnum.transaction, | ||
| startTimestamp: getUnixTimestamp(), | ||
| toastId: | ||
| toastId || `transaction-toast-${state.transactionToasts.length + 1}` |
There was a problem hiding this comment.
check vulenrability here if there is one
There was a problem hiding this comment.
i did the same thing as in custom case
| @@ -0,0 +1,11 @@ | |||
| import { StoreType } from 'store/store.types'; | |||
|
|
|||
| export const networkSliceSelector = ({ network }: StoreType) => network; | |||
| import { TransactionServerStatusesEnum } from 'types/enums.types'; | ||
| import { SignedTransactionType } from 'types/transactions.types'; | ||
|
|
||
| export const transactionsSliceSelector = ({ trackedTransactions }: StoreType) => |
There was a problem hiding this comment.
trackedTransactionsSliceSelector
| * | ||
| * **⚠️ Warning**: Toasts with components will not be persisted on page reload because React components are not serializable | ||
| */ | ||
| component: (() => JSX.Element) | null; |
There was a problem hiding this comment.
is this used? since we are no longer in React
There was a problem hiding this comment.
i removed for now all the custom types and let only the generic one
| @@ -0,0 +1,82 @@ | |||
| import { JSX } from 'react'; | |||
There was a problem hiding this comment.
why do we have react in the project?
Feature
added transaction tracking
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests