Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.6 #1382

Merged
merged 6 commits into from
Mar 11, 2025
Merged

v3.2.6 #1382

merged 6 commits into from
Mar 11, 2025

Conversation

MiroMargineanu
Copy link
Contributor

@MiroMargineanu MiroMargineanu commented Mar 11, 2025

Issue

Signing transactions on the extension would break the layout, creating an unnecessary scroll and spacing the elements out more than necessary.

Reproduce

Signing a transaction with the extension while not in full screen mode, that will also trigger the extension to not open in full screen mode.

Issue exists on v3.2.5 of sdk-dapp.

Fix

Aligned the buttons on the same row and slightly altered the spacing.

Contains breaking changes

  • No
  • Yes

Updated CHANGELOG

  • No
  • Yes

Testing

  • User testing
  • Unit tests

@MiroMargineanu MiroMargineanu self-assigned this Mar 11, 2025
@MiroMargineanu MiroMargineanu added the enhancement New feature or request label Mar 11, 2025
@MiroMargineanu MiroMargineanu marked this pull request as ready for review March 11, 2025 15:55
@MiroMargineanu MiroMargineanu merged commit dd29967 into main Mar 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants