Delegation transaction intents factory #328

popenta · 2023-09-05T11:57:16Z

Implemented the delegation transaction intents factory based on the sdk-specs.

danielailie · 2023-09-11T09:11:58Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+        }).build();
+    }
+
+    private computeExecutionGasLimitForNodesManagement(numNodes: number): BigNumber.Value {


can you please move this at the end of the file or maybe decide on a pattern, first public then private?

Moved to the end of file.

andreibancioiu · 2023-09-08T11:40:57Z

src/transactionIntentsFactories/smartContractTransactionIntentsFactory.spec.ts

@@ -140,23 +141,12 @@ describe("test smart contract intents factory", function () {
        assert.equal(deployIntent.sender, "erd1qyu5wthldzr8wx5c9ucg8kjagg0jfs53s8nr3zpz3hypefsdd8ssycr6th");
        assert.equal(deployIntent.receiver, "erd1qqqqqqqqqqqqqpgqhy6nl6zq07rnzry8uyh6rtyq0uzgtk3e69fqgtz9l4");
        assert.isDefined(deployIntent.data);
-        assert(checkIfByteArrayStartsWith(deployIntent.data!, "upgradeContract@"));
+        assert.isTrue(Buffer.from(deployIntent.data!).toString().startsWith("upgradeContract@"));


andreibancioiu · 2023-09-11T09:17:20Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.spec.ts

+import { SignableMessage } from "../signableMessage";
+
+describe("test delegation intents factory", function () {
+    const delegationFactory = new DelegationTransactionIntentsFactory({


If we add a config like here:

https://github.com/multiversx/mx-sdk-py-core/blob/main/multiversx_sdk_core/transaction_intents_factories/transaction_intents_factory_config.py

Then we can also use it in the unit tests (easier).

Created the config file.

andreibancioiu · 2023-09-11T09:18:24Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.spec.ts

+        additionalGasLimitForDelegationOperations: 10000000
+    });
+
+    it("should build intent for new delegation contract", async function () {


Now I see, we can change "should build" to "should create" (optional, "philosophical").

Changed to should create

andreibancioiu · 2023-09-11T09:19:39Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.spec.ts

+    it("should build intent for new delegation contract", async function () {
+        const sender = Address.fromBech32("erd18s6a06ktr2v6fgxv4ffhauxvptssnaqlds45qgsrucemlwc8rawq553rt2");
+        const delagationCap = new BigNumber("5000000000000000000000");
+        const serviceFee = new BigNumber(10);


We can also use raw strings and numbers, and the factory methods should be able to handle them appropriately. Perhaps do this in some tests? E.g. directly pass "5000000000000000000000".

Changed this test, works as expected.

andreibancioiu · 2023-09-11T09:21:37Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.spec.ts

+            sender: sender,
+            delegationContract: delegationContract,
+            publicKeys: [publicKey],
+            signedMessages: [signedMessage.getSignature()]


Since it's a mock message, we can do:

const mockMessage = { getSignature: () => Buffer.from("...", hex) }

Should work. Then, we'll remove new SignableMessage() and applySignature() from the test.

andreibancioiu · 2023-09-11T09:34:14Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+        let dataParts = ["addNodes"];
+        for (let i = 0; i < numNodes; i++) {
+            dataParts = dataParts.concat(options.publicKeys[i].hex());
+            dataParts = dataParts.concat(byteArrayToHex(options.signedMessages[i]));
+        }
+


If possible, we can have const dataParts, and use .push().

we have const dataParts and are using .push() now

andreibancioiu · 2023-09-11T09:37:24Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+        let dataParts = ["removeNodes"];
+
+        for (const key of options.publicKeys) {
+            dataParts = dataParts.concat(key.hex());


I am not sure why concat works fine in this case. Does the compiler complain if you add the typing markers dataParts: string[] = ...? Perhaps use append, as mentioned in the comment above?

Now using push(). It does not complain if I add typing markers but it already shows the correct type.

andreibancioiu · 2023-09-11T09:39:18Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+        }
+
+        const numNodes = options.publicKeys.length;
+        const executionGasLimit = new BigNumber(numNodes).multipliedBy(


Can be split, a temporary variable can be used.

andreibancioiu · 2023-09-11T09:40:02Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+        let dataParts = ["unJailNodes"];
+
+        for (const key of options.publicKeys) {
+            dataParts = dataParts.concat(key.hex());


append vs. concat.

now using push()

andreibancioiu · 2023-09-11T09:40:52Z

src/transactionIntentsFactories/delegationTransactionIntentsFactory.ts

+    createTransactionIntentForNewDelegationContract(options: {
+        sender: IAddress,
+        totalDelegationCap: BigNumber.Value,
+        serviceFee: BigNumber.Value,


Indeed, we receive as the BigNumber.Value interface.

start delegation transaction intents factory

c3d7468

popenta self-assigned this Sep 5, 2023

popenta marked this pull request as draft September 5, 2023 11:57

popenta added 2 commits September 6, 2023 12:16

delegation transaction intents factory

5ca9d42

started refactoring

d31bb91

Base automatically changed from sc-intents-factories to feat/factories September 8, 2023 09:39

popenta added 3 commits September 8, 2023 12:46

refactoring

23ad3be

Merge branch 'feat/factories' into delegation-intents-factories

2d30d59

fixes after merge

28d6a07

popenta marked this pull request as ready for review September 8, 2023 11:32

add trailing semicolon

5a0813c

danielailie reviewed Sep 11, 2023

View reviewed changes

andreibancioiu reviewed Sep 11, 2023

View reviewed changes

fixes after review

41604d0

andreibancioiu approved these changes Sep 11, 2023

View reviewed changes

danielailie approved these changes Sep 11, 2023

View reviewed changes

popenta merged commit 3afd6cc into feat/factories Sep 11, 2023
1 check passed

popenta deleted the delegation-intents-factories branch September 11, 2023 12:25

popenta mentioned this pull request Feb 13, 2024

v13: Merge feat/next into main #347

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delegation transaction intents factory #328

Delegation transaction intents factory #328

popenta commented Sep 5, 2023 •

edited

Loading

danielailie Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 8, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

popenta Sep 11, 2023

andreibancioiu Sep 11, 2023

Delegation transaction intents factory #328

Delegation transaction intents factory #328

Conversation

popenta commented Sep 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

popenta commented Sep 5, 2023 •

edited

Loading