Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AddressValue to accept custom HRPs #481

Merged

Conversation

michavie
Copy link
Contributor

AddressValue currently throws the following when providing an address with custom human-readable parts:

ErrAddressBadHrp ErrAddressBadHrp [Error]: Wrong address HRP. Expected: erd, got xyz

@andreibancioiu andreibancioiu self-requested a review September 23, 2024 07:50
@andreibancioiu andreibancioiu merged commit 04376f6 into multiversx:main Sep 23, 2024
2 checks passed
@andreibancioiu
Copy link
Contributor

@michavie, thanks for the PR 🙌

Released here: https://github.com/multiversx/mx-sdk-js-core/releases/tag/v13.6.3.

@andreibancioiu
Copy link
Contributor

Additional notes for community, when one needs to alter the default HRP:

import LibraryConfig from both sdk-core and sdk-wallet

LibraryConfigOfSdkCore.DefaultAddressHrp = "xyz";

...

LibraryConfigOfSdkWallet.DefaultAddressHrp = "xyz";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants