Add token Management controller #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
TOOL-356-add-smart-contracts-controller
to
feat/next
November 18, 2024 08:06
popenta
reviewed
Nov 18, 2024
| import { IAccount } from "../accounts/interfaces"; | ||
| import { TransactionOnNetwork } from "../networkProviders"; | ||
| import { INetworkProvider } from "../networkProviders/interface"; | ||
| import { IESDTIssueOutcome } from "../tokenOperations"; |
There was a problem hiding this comment.
the tokenOperations package will be removed and we should not import from there.
There was a problem hiding this comment.
I will to this when I will remove the package
| @@ -15,7 +15,7 @@ export class ContractController { | |||
| this.provider = provider; | |||
| this.transactionCompletionAwaiter = new TransactionWatcher({ | |||
| getTransaction: async (hash: string) => { | |||
| return await provider.getTransaction(hash, true); | |||
| return await provider.getTransaction(hash); | |||
There was a problem hiding this comment.
Can we pass the network provider directly?
| @@ -39,7 +33,7 @@ export function createMainnetProvider(): INetworkProvider { | |||
| export interface INetworkProvider { | |||
| getNetworkConfig(): Promise<INetworkConfig>; | |||
| getAccount(address: IAddress): Promise<IAccountOnNetwork>; | |||
| getTransaction(txHash: string, withProcessStatus?: boolean): Promise<ITransactionOnNetwork>; | |||
| getTransaction(txHash: string): Promise<TransactionOnNetwork>; | |||
There was a problem hiding this comment.
Indeed, good to drop this flag.
andreibancioiu
approved these changes
Nov 18, 2024
popenta
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.