Update TransactionOnNetwork to follow specs #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/transactionOnNetwork.ts
Outdated
| result.logs = TransactionLogs.fromHttpResponse(response.logs || {}); | ||
| // result.raw = response; |
src/transactionWatcher.ts
Outdated
| throw new ErrIsCompletedFieldIsMissingOnTransaction(); | ||
| } | ||
| return transactionOnNetwork.isCompleted; | ||
| return transactionOnNetwork.status.isExecuted(); |
There was a problem hiding this comment.
Is this correct (execution vs. completion)?
There was a problem hiding this comment.
Oh, yes, since it's the process status.
andreibancioiu
previously approved these changes
Jan 14, 2025
popenta
reviewed
Jan 14, 2025
src/transactionOnNetwork.ts
Outdated
| function: string = ""; | ||
| data: Buffer = Buffer.from([]); | ||
| version: number = 0; | ||
| options: number = 0; | ||
| signature: string = ""; |
There was a problem hiding this comment.
in specs the signature is of type bytes.
Comment on lines
+56
to
+57
| miniblockHash: string = ""; | ||
| blockHash: string = ""; |
There was a problem hiding this comment.
these are also of type bytes in the specs.
There was a problem hiding this comment.
for the extra work to display this in js we will let them string because the hash is usually display
Comment on lines
+39
to
+50
| /** | ||
| * Returns whether the transaction has been conpleted (not necessarily with success). | ||
| */ | ||
| isCompleted(): boolean { | ||
| return this.isSuccessful() || this.isFailed() || this.isInvalid(); | ||
| } | ||
|
|
||
| /** | ||
| * Returns whether the transaction has been executed successfully. | ||
| */ | ||
| isSuccessful(): boolean { | ||
| return ( | ||
| this.status == "executed" || | ||
| this.status == "success" || | ||
| this.status == "successful" | ||
| ); | ||
| return this.status == "executed" || this.status == "success" || this.status == "successful"; |
There was a problem hiding this comment.
Maybe also add the boolean members as well?
popenta
reviewed
Jan 14, 2025
src/transactionOnNetwork.ts
Outdated
| @@ -50,7 +50,7 @@ export class TransactionOnNetwork { | |||
| data: Buffer = Buffer.from([]); | |||
| version: number = 0; | |||
| options: number = 0; | |||
| signature: string = ""; | |||
| signature?: Uint8Array; | |||
There was a problem hiding this comment.
Should not be optional and you can set the default value to an empty Uint8Array.
popenta
approved these changes
Jan 14, 2025
andreibancioiu
approved these changes
Jan 14, 2025
danielailie
deleted the
TOOL-410-update-transaction-on-network-to-follow-specs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.