Update tests to use account.signTransaction #571

danielailie · 2025-01-30T11:53:58Z

No description provided.

andreibancioiu · 2025-01-30T15:07:05Z

src/core/transaction.spec.ts


-        const userVerifier = new UserVerifier(new UserPublicKey(wallets.alice.address.getPublicKey()));
+        const userVerifier = new UserVerifier(alice.publicKey);


Can use account.verify()?

Now I see, that we don't have separate verify_transaction and verify_message:

https://github.com/multiversx/mx-sdk-specs/blob/main/accounts/account.md

How about having so?

andreibancioiu · 2025-01-30T15:07:28Z

src/networkProviders/apiNetworkProvider.dev.net.spec.ts

@@ -373,7 +365,7 @@ describe("ApiNetworkProvider Tests", function () {
            data: new Uint8Array(Buffer.from("dummy@05")),
        });
        transaction.nonce = nonce + 1n;
-        transaction.signature = await bob.signer.sign(transactionComputer.computeBytesForSigning(transaction));
+        transaction.signature = bob.signTransaction(transaction);


andreibancioiu · 2025-01-30T15:07:48Z

src/networkProviders/proxyNetworkProvider.dev.net.spec.ts

@@ -298,7 +289,7 @@ describe("ProxyNetworkProvider Tests", function () {
        let txOnNetwork = await proxy.simulateTransaction(transaction);
        assert.deepEqual(txOnNetwork.status, new TransactionStatus("success"));

-        transaction.signature = await bob.signer.sign(transactionComputer.computeBytesForSigning(transaction));
+        transaction.signature = bob.signTransaction(transaction);


await - here and in other places, as needed?

popenta · 2025-01-31T10:39:12Z

src/abi/interaction.local.net.spec.ts

+        deployTransaction.nonce = alice.getNonceThenIncrement();

-        deployTransaction.signature = await alice.signer.sign(
-            Buffer.from(transactionComputer.computeBytesForSigning(deployTransaction)),
-        );
+        deployTransaction.signature = alice.signTransaction(deployTransaction);

-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


if you use getNonceThenIncrement() and then try to compute the contract's address using alice.nonce you'll have a higher nonce than the one on the transaction, thus computing an invalid address.

popenta · 2025-01-31T10:40:16Z

src/abi/interaction.local.net.spec.ts

+        deployTransaction.nonce = alice.getNonceThenIncrement();

-        deployTransaction.signature = await alice.signer.sign(
-            Buffer.from(transactionComputer.computeBytesForSigning(deployTransaction)),
-        );
+        deployTransaction.signature = alice.signTransaction(deployTransaction);

-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


same comment as above

popenta · 2025-01-31T10:44:55Z

src/abi/smartContract.local.net.spec.ts


-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


same comment with the higher nonce and wrong contract address.

popenta · 2025-01-31T10:45:39Z

src/abi/smartContract.local.net.spec.ts


-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


same issue here

popenta · 2025-01-31T10:46:24Z

src/abi/smartContract.local.net.spec.ts


-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


same issue here, as well

popenta · 2025-01-31T10:47:06Z

src/abi/smartContract.local.net.spec.ts


-        const contractAddress = SmartContract.computeAddress(alice.address, alice.account.nonce);
-        alice.account.incrementNonce();
+        const contractAddress = SmartContract.computeAddress(alice.address, alice.nonce);


same issue here.

danielailie added 3 commits January 30, 2025 13:49

Update tests to use account.signTransaction

94d246c

Fix tests

ff2520e

Fix integration tests

206d6ca

andreibancioiu assigned danielailie Jan 30, 2025

andreibancioiu reviewed Jan 30, 2025

View reviewed changes

popenta reviewed Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tests to use account.signTransaction #571

Update tests to use account.signTransaction #571

danielailie commented Jan 30, 2025

andreibancioiu Jan 30, 2025

andreibancioiu Jan 30, 2025

andreibancioiu Jan 30, 2025

popenta Jan 31, 2025

popenta Jan 31, 2025

popenta Jan 31, 2025

popenta Jan 31, 2025

popenta Jan 31, 2025

popenta Jan 31, 2025


		const userVerifier = new UserVerifier(new UserPublicKey(wallets.alice.address.getPublicKey()));
		const userVerifier = new UserVerifier(alice.publicKey);

Update tests to use account.signTransaction #571

Are you sure you want to change the base?

Update tests to use account.signTransaction #571

Conversation

danielailie commented Jan 30, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment