Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright to precommit and format files #181

Merged
merged 5 commits into from
Jan 17, 2025
Merged

Conversation

popenta
Copy link
Collaborator

@popenta popenta commented Jan 16, 2025

Added pyright to run as a pre-commit hook.
Exclude proto generated files when running flake8.
Format code.

Link to pyright: https://github.com/microsoft/pyright/blob/main/docs/ci-integration.md#running-pyright-as-a-pre-commit-hook

@popenta popenta self-assigned this Jan 16, 2025
Copy link

github-actions bot commented Jan 16, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  multiversx_sdk/abi
  abi.py 130, 197
  abi_definition.py
  bigint_value.py 32
  code_metadata_value.py
  enum_value.py 81, 91, 150
  managed_decimal_signed_value.py
  managed_decimal_value.py
  option_value.py
  small_int_values.py 82
  tuple_value.py 37
  multiversx_sdk/core
  address.py
  bech32.py
  tokens.py 167
  transaction.py
  multiversx_sdk/entrypoints
  entrypoints.py 90
  multiversx_sdk/network_providers
  api_network_provider.py 127
  proxy_network_provider.py 155
  transaction_decoder.py 37, 83
  multiversx_sdk/smart_contracts
  smart_contract_controller.py
  smart_contract_transactions_outcome_parser.py 118
  multiversx_sdk/testutils
  mock_network_provider.py
  multiversx_sdk/token_management
  token_management_transactions_outcome_parser.py
  multiversx_sdk/wallet
  user_keys.py
  validator_keys.py
  multiversx_sdk/wallet/libraries
  bls_facade.py
Project Total  

The report is truncated to 25 files out of 87. To see the full report, please visit the workflow summary page.

This report was generated by python-coverage-comment-action

Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merge it only after #177 (to avoid conflicts).

@@ -29,3 +29,7 @@ repos:
args:
- --in-place
- --remove-all-unused-imports
- repo: https://github.com/RobertCraigie/pyright-python
rev: v1.1.392
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PR description, please add a link towards a page that recommends (endorses) this extension.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

danielailie
danielailie previously approved these changes Jan 16, 2025
andreibancioiu
andreibancioiu previously approved these changes Jan 17, 2025
@popenta popenta dismissed stale reviews from andreibancioiu and danielailie via 14fc405 January 17, 2025 08:47
@popenta popenta merged commit d8c53dc into feat/next Jan 17, 2025
6 checks passed
@popenta popenta deleted the add-pyright-precommit branch January 17, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants