-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyright to precommit and format files #181
Conversation
Coverage reportClick to see where and how coverage changed
The report is truncated to 25 files out of 87. To see the full report, please visit the workflow summary page. This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe merge it only after #177 (to avoid conflicts).
@@ -29,3 +29,7 @@ repos: | |||
args: | |||
- --in-place | |||
- --remove-all-unused-imports | |||
- repo: https://github.com/RobertCraigie/pyright-python | |||
rev: v1.1.392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PR description, please add a link towards a page that recommends (endorses) this extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
14fc405
Added pyright to run as a pre-commit hook.
Exclude proto generated files when running flake8.
Format code.
Link to pyright: https://github.com/microsoft/pyright/blob/main/docs/ci-integration.md#running-pyright-as-a-pre-commit-hook