Fix for sending message with ESDTTransfer for transaction decoder #186
Conversation
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
| @@ -15,6 +15,10 @@ def __init__(self) -> None: | |||
| self.function_name: Optional[str] = None | |||
| self.function_args: Optional[list[str]] = None | |||
| self.transfers: Optional[list[TokenTransfer]] = None | |||
| self.message: Optional[list[str]] = None | |||
There was a problem hiding this comment.
If list, then plural. Also, can be transfer_messages, maybe? I think bytes, instead of str? Also, can be non-optional. Empty is not applicable.
There was a problem hiding this comment.
renamed and changed typed to bytes.
| @@ -106,9 +114,15 @@ def get_esdt_transaction_metadata(self, metadata: TransactionMetadata) -> Option | |||
| result.value = value | |||
| result.transfers = [] | |||
|
|
|||
| receiver = Address.new_from_bech32(result.receiver) | |||
There was a problem hiding this comment.
How about the same case for NFT transfers or multi transfers? In that case, I think receiver.is_smart_contract() would not be appropriate.
There was a problem hiding this comment.
did the same for nft and multi transfer.
| @@ -89,7 +89,7 @@ def get_normal_transaction_metadata(self, transaction: TransactionOnNetwork) -> | |||
| if len(args) == 0 and not transaction.receiver.is_smart_contract(): | |||
| metadata.function_name = "transfer" | |||
| metadata.function_args = [] | |||
| metadata.message = data_components | |||
| metadata.transfer_messages = [data.encode() for data in data_components] | |||
There was a problem hiding this comment.
Since transfer_messages holds an array of bytes, and data_components contains hex-encoded components, apply a decoding from hex, to get the raw byes? Sorry if I'm mistaken.
| @@ -159,8 +159,11 @@ def get_nft_transfer_metadata(self, metadata: TransactionMetadata) -> Optional[T | |||
| result.transfers = [] | |||
|
|
|||
| if len(args) > 4: | |||
| result.function_name = self.hex_to_string(args[4]) | |||
| result.function_args = args[5:] | |||
| if receiver.is_smart_contract(): | |||
There was a problem hiding this comment.
Here, receiver is the actual receiver of the tokens, not tx.receiver, correct?
There was a problem hiding this comment.
yep, the actual receiver
No description provided.