reviewdog: Too many results (annotations) in diff. You may miss some annotations due to GitHub limitation for annotation created by logging command. Please check GitHub Actions log console to see all results. Limitation: - 10 warning annotations and 10 error annotations per step - 50 annotations per job (sum of annotations from all the steps) - 50 annotations per run (separate from the job annotations, these annotations aren't created by users) Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835

reviewdog exited with status code: 1

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/api/managed_types/handles.rs:22:5 | 22 | unsafe fn unsafe_clone(&self) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default Raw Output: framework/base/src/api/managed_types/handles.rs:22:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/api/managed_types/handles.rs:22:5 | 22 | unsafe fn unsafe_clone(&self) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/api/managed_types/handles.rs:22:5 | 22 | unsafe fn unsafe_clone(&self) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default Raw Output: framework/base/src/api/managed_types/handles.rs:22:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/api/managed_types/handles.rs:22:5 | 22 | unsafe fn unsafe_clone(&self) -> Self; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default __END__

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:16:5 | 16 | unsafe fn get_unsafe_handle(&self) -> <Self as ManagedType<M>>::OwnHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc Raw Output: framework/base/src/types/managed/managed_type_trait.rs:16:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:16:5 | 16 | unsafe fn get_unsafe_handle(&self) -> <Self as ManagedType<M>>::OwnHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc __END__

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:29:5 | 29 | unsafe fn get_raw_handle(&self) -> RawHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc Raw Output: framework/base/src/types/managed/managed_type_trait.rs:29:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:29:5 | 29 | unsafe fn get_raw_handle(&self) -> RawHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc __END__

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:16:5 | 16 | unsafe fn get_unsafe_handle(&self) -> <Self as ManagedType<M>>::OwnHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc Raw Output: framework/base/src/types/managed/managed_type_trait.rs:16:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:16:5 | 16 | unsafe fn get_unsafe_handle(&self) -> <Self as ManagedType<M>>::OwnHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc __END__

[clippy] reported by reviewdog 🐶 warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:29:5 | 29 | unsafe fn get_raw_handle(&self) -> RawHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc Raw Output: framework/base/src/types/managed/managed_type_trait.rs:29:5:w:warning: unsafe function's docs miss `# Safety` section --> framework/base/src/types/managed/managed_type_trait.rs:29:5 | 29 | unsafe fn get_raw_handle(&self) -> RawHandle { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc __END__

[clippy] reported by reviewdog 🐶 warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:148:40 | 148 | let token_id_len = self.mb_len(&token_id_handle); | ^^^^^^^^^^^^^^^^ help: change this to: `token_id_handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:148:40:w:warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:148:40 | 148 | let token_id_len = self.mb_len(&token_id_handle); | ^^^^^^^^^^^^^^^^ help: change this to: `token_id_handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__

[clippy] reported by reviewdog 🐶 warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:168:40 | 168 | let token_id_len = self.mb_len(&token_id_handle); | ^^^^^^^^^^^^^^^^ help: change this to: `token_id_handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:168:40:w:warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/core_api_vh/blockchain_api_vh.rs:168:40 | 168 | let token_id_len = self.mb_len(&token_id_handle); | ^^^^^^^^^^^^^^^^ help: change this to: `token_id_handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__

[clippy] reported by reviewdog 🐶 warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/impl_vh/vm_hooks_api.rs:104:28 | 104 | self.mb_load_slice(&handle, 0, &mut temp_buffer[..length]) | ^^^^^^^ help: change this to: `handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow Raw Output: framework/scenario/src/api/impl_vh/vm_hooks_api.rs:104:28:w:warning: this expression creates a reference which is immediately dereferenced by the compiler --> framework/scenario/src/api/impl_vh/vm_hooks_api.rs:104:28 | 104 | self.mb_load_slice(&handle, 0, &mut temp_buffer[..length]) | ^^^^^^^ help: change this to: `handle` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow __END__