Hackathon feat #1246
Open
Hackathon feat #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feat is especially useful when updating EsdtRoles for SC deployed when using the rust testing framework. Prior to this, setting the roles will overwrite all contract storage values.
…n no previous entry for token_id
Since I learnt from [here](multiversx#808) that this can be any arbitrary value, and this is currently causing tests to fail in my work space, setting this value to `u64::MAX` seems okay
|
Looks cool, but we must first make sure that the changes are compatible with the Go implementation. |
|
Alright. Let me know if there's anything I should do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates I made during the hackathon.