-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the adder interactor example to work with keystore-signing #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrei Vasilescu <[email protected]>
Coverage SummaryTotals
FilesExpand
|
Contract comparison - from 5b28351 to 3e46541
|
Co-authored-by: Andrei Vasilescu <[email protected]>
Co-authored-by: Andrei Vasilescu <[email protected]>
BiancaIalangi
previously approved these changes
Aug 28, 2024
mihaicalinluca
requested changes
Aug 28, 2024
Co-authored-by: Andrei Vasilescu <[email protected]>
Co-authored-by: Andrei Vasilescu <[email protected]>
mihaicalinluca
requested changes
Aug 28, 2024
Co-authored-by: Andrei Vasilescu <[email protected]>
mihaicalinluca
requested changes
Aug 29, 2024
.prepare_async() | ||
.run() | ||
.await; | ||
|
||
let sum = self |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the query, but only do it when expected result is success
andrei-marinica
requested changes
Aug 29, 2024
Co-authored-by: Andrei Vasilescu <[email protected]>
andrei-marinica
approved these changes
Sep 2, 2024
BiancaIalangi
approved these changes
Sep 3, 2024
mihaicalinluca
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We modified the function from_keystore_secret to get the password as an argument instead of requesting it from the terminal.