Skip to content

detect write op in view storage - refactor: removed has_format, chang…

Sign in for the full log view
GitHub Actions / clippy failed Sep 13, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (4)

framework/meta-lib/src/tools/wasm_extractor.rs|73 col 21| warning: assigning the result of ToOwned::to_owned() may be inefficient
--> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
|
73 | wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use clone_into(): WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: #[warn(clippy::assigning_clones)] on by default
framework/meta-lib/src/tools/wasm_extractor.rs|75 col 21| warning: assigning the result of ToOwned::to_owned() may be inefficient
--> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
|
75 | wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use clone_into(): WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
framework/meta-lib/src/tools/wasm_extractor.rs|73 col 21| warning: assigning the result of ToOwned::to_owned() may be inefficient
--> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
|
73 | wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use clone_into(): WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: #[warn(clippy::assigning_clones)] on by default
framework/meta-lib/src/tools/wasm_extractor.rs|75 col 21| warning: assigning the result of ToOwned::to_owned() may be inefficient
--> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
|
75 | wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use clone_into(): WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Filtered Findings (0)

Annotations

Check warning on line 73 in framework/meta-lib/src/tools/wasm_extractor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/meta-lib/src/tools/wasm_extractor.rs#L73

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
   |
73 |                     wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
   = note: `#[warn(clippy::assigning_clones)]` on by default
Raw output
framework/meta-lib/src/tools/wasm_extractor.rs:73:21:w:warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
   |
73 |                     wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
   = note: `#[warn(clippy::assigning_clones)]` on by default


__END__

Check warning on line 75 in framework/meta-lib/src/tools/wasm_extractor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/meta-lib/src/tools/wasm_extractor.rs#L75

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
   |
75 |                     wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Raw output
framework/meta-lib/src/tools/wasm_extractor.rs:75:21:w:warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
   |
75 |                     wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones


__END__

Check warning on line 73 in framework/meta-lib/src/tools/wasm_extractor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/meta-lib/src/tools/wasm_extractor.rs#L73

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
   |
73 |                     wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
   = note: `#[warn(clippy::assigning_clones)]` on by default
Raw output
framework/meta-lib/src/tools/wasm_extractor.rs:73:21:w:warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:73:21
   |
73 |                     wasm_info.report.has_panic = WITH_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITH_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
   = note: `#[warn(clippy::assigning_clones)]` on by default


__END__

Check warning on line 75 in framework/meta-lib/src/tools/wasm_extractor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/meta-lib/src/tools/wasm_extractor.rs#L75

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
   |
75 |                     wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
Raw output
framework/meta-lib/src/tools/wasm_extractor.rs:75:21:w:warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> framework/meta-lib/src/tools/wasm_extractor.rs:75:21
   |
75 |                     wasm_info.report.has_panic = WITHOUT_MESSAGE.to_owned();
   |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `WITHOUT_MESSAGE.clone_into(&mut wasm_info.report.has_panic)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones


__END__