Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support displaying the dot character in SegmentDisplay. #198

Merged
merged 11 commits into from
May 1, 2019
Merged

Conversation

mum4k
Copy link
Owner

@mum4k mum4k commented Apr 29, 2019

Fixes #183

Steps:

  • Factor code common to multiple segment display types out of the sixteen package.
  • Create a new segment display type that can display a dot and a colon.
  • Update SegmentDisplay to use the new display type.

Moving out code that is common to all segment display types.
@mum4k mum4k marked this pull request as ready for review May 1, 2019 03:05
@coveralls
Copy link

coveralls commented May 1, 2019

Pull Request Test Coverage Report for Build 1115

  • 211 of 238 (88.66%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 92.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/segdisp/segdisp.go 31 33 93.94%
internal/segdisp/dotseg/dotseg.go 84 90 93.33%
widgets/segmentdisplay/segmentdisplay.go 17 26 65.38%
internal/segdisp/dotseg/attributes.go 46 56 82.14%
Files with Coverage Reduction New Missed Lines %
widgets/segmentdisplay/segmentdisplay.go 1 85.71%
Totals Coverage Status
Change from base Build 1107: -0.1%
Covered Lines: 7280
Relevant Lines: 7874

💛 - Coveralls

@mum4k mum4k merged commit e6a00d5 into devel May 1, 2019
@mum4k mum4k deleted the dot-display branch May 1, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants