Allow alternative area explicit sizing in splits #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Releasing Termdash v0.19.0. ## Added - Support for "Backtab" (a.k.a. Shift+Tab) as a supported keystroke for tcell widgets. ## Changed - Migrated CI from Travis to Github Actions. - Bump github.com/gdamore/tcell/v2 from 2.5.4 to 2.7.0. - Change the Go version in `go.mod` to 1.21. - Executed `go mod tidy`. - CI now executes tests with Golang v1.20 and v1.21.
spacez320
changed the title
mum4k
requested changes
Mar 6, 2024
spacez320
force-pushed
the
292-allow-splitfixed-to-set-the-size-of-the-second-container
branch
from
7b0b370 to
ec14443
Compare
spacez320
changed the title
mum4k
approved these changes
Mar 10, 2024
There was a problem hiding this comment.
Thank you again for the contribution @spacez320. Appreciate the included test coverage and the fixess to existing docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows one to apply split options that affect the size of either area elements in a split, whereas previously only the first area element could be explicitly sized.
Users can accomplish this by providing
SplitFixedFromEndorSpltPercentFromEndoptions to containers, mirroring the existingSplitFixedandSplitPercent.A list of changes involved in this PR include:
splitReversedto indicate when the alternative area should be targeted with an explicit size. By default, this isfalse, retaining existing behavior.SplitFixedFromEndandSplitPercentFromEnd.HSplitReversedandVSplitReversedto mirrorHSplitandVSplit. Common logic for these functions is isolated to privatehSplitandvSplitfunctions used respectively. Added similar functions for percentage variants.Fixes #292