Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Param type to Function #559

Merged
merged 4 commits into from
Apr 13, 2024
Merged

Conversation

baszalmstra
Copy link
Collaborator

Adds the Param type to Function which gives access to the source of the parameter.

I also fixed a few deprecation warnings.

@baszalmstra baszalmstra requested a review from Wodann April 3, 2024 14:38
@Wodann
Copy link
Collaborator

Wodann commented Apr 4, 2024

The changes look good to me, but there is a CI failure due to a deprecated member variable being used.

@baszalmstra
Copy link
Collaborator Author

The changes look good to me, but there is a CI failure due to a deprecated member variable being used.

I think I fixed it by pinning lsp-types for now.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 67.01031% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 87.40%. Comparing base (b68a952) to head (9c8de22).

Files Patch % Lines
crates/mun_hir/src/code_model/function.rs 0.00% 30 Missing ⚠️
crates/mun_hir/src/item_tree.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
+ Coverage   87.30%   87.40%   +0.10%     
==========================================
  Files         276      276              
  Lines       32035    32157     +122     
==========================================
+ Hits        27968    28108     +140     
+ Misses       4067     4049      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baszalmstra baszalmstra merged commit d86d49a into mun-lang:main Apr 13, 2024
17 of 18 checks passed
@baszalmstra baszalmstra deleted the feat/params branch April 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants