Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split mltrain #82

Merged
merged 11 commits into from
Oct 24, 2024
Merged

split mltrain #82

merged 11 commits into from
Oct 24, 2024

Conversation

vbrunn
Copy link
Contributor

@vbrunn vbrunn commented Oct 17, 2024

split mltrain into traindata (enabling extration of preliminary tree map in rast and vect format) and mltrain (doing the random forest training)

@griembauer
Copy link
Member

Todo: Update top-level Readme - all addons are listed and summarized there

@vbrunn
Copy link
Contributor Author

vbrunn commented Oct 23, 2024

include a check if the map trees_pixel_ndvi exists at beginning of r.trees.mltrain:
if not grass.find_file(name=trees_pixel_ndvi):
grass.fatal(_(f"The map {trees_pixel_ndvi} does not exist. Addon run is stopped.",))

README.md Outdated
@@ -39,8 +39,9 @@ Repo for code and script transfer between mundialis and RVR - GRASS GIS addons:
- **m.analyse.trees**

- **r.trees.peaks** assigns pixels to nearest peak (tree crown).
- **r.trees.mltrain** generates training data for a machine learning (ML)
model to detect trees and trains the model with these training data.
- **r.trees.peaks** generates training data for a machine learning (ML)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **r.trees.peaks** generates training data for a machine learning (ML)
- **r.trees.traindata** generates training data for a machine learning (ML)

@vbrunn vbrunn marked this pull request as ready for review October 24, 2024 07:28
Copy link
Member

@griembauer griembauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a very small naming suggestion


# %option G_OPT_R_OUTPUT
# % key: traindata_r
# % label: primary tree map as raster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# % label: primary tree map as raster
# % label: Preliminary tree map as raster

# %option G_OPT_V_OUTPUT
# % key: traindata_v
# % label: primary tree map as vector
# % description: Primary tree map in vector format to export and edit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# % description: Primary tree map in vector format to export and edit
# % description: Preliminary tree map in vector format to export and edit

@vbrunn vbrunn merged commit 2633042 into main Oct 24, 2024
7 checks passed
@vbrunn vbrunn deleted the ml_schalter branch October 24, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants