feat: link previews #305
Open
feat: link previews #305
+225
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip: move parsing to markdown marked extension
sameoldlab
force-pushed
the
feat/link-previews
branch
from
f20722c to
8a8a34d
Compare
zicklag
reviewed
Feb 10, 2025
Comment on lines
24
to
29
| $effect(() => { | ||
| data.page.html; | ||
| untrack(() => { | ||
| previewLinks(data.page.html).then((res) => (html = res)); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Is this effect necessary? If the HTML changes it should be when we go to another page and in that case the preview links will already have been rendered by the server right?
There was a problem hiding this comment.
It could be taken out. I noticed some delay when loading pages with a lot of link previews (largest page I tried had 10 links, but was also from my local connection to the link service), so the effect was there for a second attempt to resolve any links that timed out server-side.
There was a problem hiding this comment.
In hopes that the link service's caching should prevent issues after the first load, lets take it out for now and see how it does on the main site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds link previews to articles. (closes #241)