feat: support setting ICE ufrag and pwd, disabling fingerprint validation and specifying certificates #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
changed the title
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jun 7, 2024
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
12 tasks
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jun 7, 2024
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
|
Thanks for the PR. |
achingbrain
force-pushed
the
feat/support-setting-ufrag-and-pwd
branch
from
2e41beb
to
4cb6ad1
Compare
Updates the implementation to match the latest libdatachannel with features for setting ICE ufrag/pwd and reading the remote cert fingerprint. Also adds pass-through for missing config values.
achingbrain
force-pushed
the
feat/support-setting-ufrag-and-pwd
branch
from
4c8b9b6
to
10051a8
Compare
|
Hello, When that could be ready for merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paullouisageneau/libjuice#243 allows setting the ICE ufrag and pwd fields instead of generating random ones every time.
paullouisageneau/libdatachannel#1207 adds an
initarg tosetLocalDescriptionto allow setting the fields in libjuice from libdatachannel.paullouisageneau/libdatachannel#1206 allows reading the fingerprint of the cert being used by the remote peer.
This PR adds the
initarg tosetLocalDescription, and theremoteFingerprintmethod, plus the missing config keys.This is required to implement libp2p WebRTC-Direct.
It will require the PRs above being merged and shipped before this is ready so I've opened it as a draft for now.
Refs: paullouisageneau/libdatachannel#1166