feat: accept preconfigured PeerConnection as polyfill arg #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases where we need to use methods on `PeerConnection` that are not available on `RTCPeerConnection`, but then we wish to pass the `RTCPeerConnection` on to other code for it to use in a polmorphic node/browser way. Add an option to the polyfilled `RTCPeerConnection` to pass a preconfigured `PeerConnection` instance in, instead of always creating one.
12 tasks
|
Thanks for the PR. |
|
It's a non standard option, true. It'll only appear as a valid option if you import the polyfill and use it directly. If you use the bundled types from |
|
As I understood this is a special case for your app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where we need to use methods on
PeerConnectionthat are not available onRTCPeerConnection, but then we wish to pass theRTCPeerConnectionon to other code for it to use in a polymorphic node/browser way.Add an option to the polyfilled
RTCPeerConnectionto pass a preconfiguredPeerConnectioninstance in, instead of always creating one.