Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very Basic support of SoundClound #1030

Closed
wants to merge 6 commits into from

Conversation

Kapppa
Copy link

@Kapppa Kapppa commented May 5, 2024

Closes #418

Adds support for SoundCloud, this is very basic support of it. Currently only supports urls no searching.

Copy link

github-actions bot commented May 6, 2024

📦 A new release has been made for this pull request.

To play around with this PR, pull codetheweb/muse:pr-1030 or codetheweb/muse:27098495267899e1f17c241ff98cf9bc47f431cf.

Images are available for x86_64 and ARM64.

Latest commit: 2709849

@codetheweb
Copy link
Collaborator

thanks! unfortunately this doesn't seem to be working for me, e.g. with https://soundcloud.com/joeyvalenceandbrae/packapunch-feat-danny-brown-1.

It adds the track to the queue and shows it as playing but the audio doesn't seem to make it to Discord.

@Kapppa
Copy link
Author

Kapppa commented Jun 24, 2024

thanks! unfortunately this doesn't seem to be working for me, e.g. with https://soundcloud.com/joeyvalenceandbrae/packapunch-feat-danny-brown-1.

It adds the track to the queue and shows it as playing but the audio doesn't seem to make it to Discord.

Works fine for me on my end. Is the IP the bot is running on blocked from soundcloud?

@Codixer Codixer self-assigned this Oct 29, 2024
@Codixer
Copy link
Contributor

Codixer commented Nov 4, 2024

@Kapppa would you have time to test and update your PR?

@DaanSelen
Copy link

What is the status of this PR?

@Codixer
Copy link
Contributor

Codixer commented Dec 10, 2024

@DaanSelen I gotta know if the changes work.

@DaanSelen
Copy link

DaanSelen commented Dec 19, 2024

@Codixer using the bot made docker container... it works!

You can try it out!

Copy link

@DaanSelen DaanSelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! But I already found some bugs! I can only play one song... and then it loops.

@DaanSelen
Copy link

I'm very hopeful for this method. But it has become out of date, perhaps if we revise the code to the current version. I am not competent enough for that but perhaps someone is willing?

@Codixer Codixer closed this Dec 19, 2024
@Codixer
Copy link
Contributor

Codixer commented Dec 19, 2024

We'll see if someone wants to work on this update. I'll check myself as well, but no promises yet.

@DaanSelen
Copy link

We'll see if someone wants to work on this update. I'll check myself as well, but no promises yet.

For me this would make Muse complete, I now need to run multiple bots for all providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoundCloud support
4 participants