-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update distube dependencies for improved YouTube support #1180
base: master
Are you sure you want to change the base?
Conversation
📦 🤖 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
@timurko-uwu @SparksSkywere @QuintenQVD0 @ascensionfm @AptGetGnome @kirankunigiri @cwerdna19 @Wancerz @WojenHere @DaanSelen @ThomasHineXYZ @aaddyy227 @arty01238 @Zereah Hello there! All of you should be having the same issue currently with Muse being unable to play music at this moment, currently... this seems like an issue with several things. Either ffmpeg being annoying, ytdl being annoying or some other issues that I currently can't find. However, in this case. It seems like YTDL seems to be the most damning issue at this moment. As it seems like we are not the only one with the issue, and timelines more or less match up with distubejs/ytdl-core#157 distubejs/ytdl-core#156 and distubejs/ytdl-core#153 If you are able to, please do the following. Add Caution MAKE SURE YOUR TOKEN/API KEY IS NOT VISIBLE IN THE LOG Additionally, if you want to take a gander, try upgrading/downgrading muse, ytdl-core and/or ffmpeg to see if this resolves your issue. As several issues are going on at a time, and I can't test all of them. |
I have tried to update every npm module as far as I can without code errors. It does not resolve it. |
I weirdly do not have the issue... what should be happening? |
What is your current env? Muse version, FFMPEG, distube, etc. Where are you hosting (and so on and so forth). |
Running inside Kubernetes 1.31.3
https://github.com/museofficial/muse/pkgs/container/muse I don't think anything else is installed by me other than the information for running. |
I ended up writing my own music bot because of this not working. While doing that I discovered that the latest release of @distube/ytdl-core, 4.15.8, is not working apparently universally. I downgraded to 4.15.4, and my bot worked. I kind of gave up on muse, and started to find justifications for my own (scuffed) bot, like there being muse dependencies that have not been updated for over 2 years, and have severe vulnerabilities. Like a VM2 dependency. Not really sure if there is a real concern for these dependency vulnerabilities. Coming back to muse, it works fine now with @distube/[email protected]. Basically, if I had probably just investigated a little bit I would have found that I needed to update ytdl (and downgrade? because the current muse package.json version is 4.14.4), but there were no errors or logs, just a silent failure. I had also apparently had issues with using different versions of node. Anyway, to verify, I stashed my changes and checked out muse v2.10.0 again to avoid any stupid package version changes I did. Just soapboxing sorry. From my experience, it appears to be working now. I didn't record which version of @distube/ytdl-core was being grabbed before. It was probably a ytdl-core issue, but I had convoluted the issue by changing dependency versions, and changing node versions. Edit2: Packages:
ffmpeg:
npm
node
OS: Ubuntu 22.04.5 LTS Sorry, should've included my env earlier. Hope this helps. Edit3: Just tested 4.15.8 for fun. It works.
I learned a lot about using node from all this, but I suppose it's possible I'm doing something wrong and using a version of ytdl installed somewhere else. I also confirmed that 4.15.8 does not work with the other music bot I made. The same behavior occurs; the bot joins then immediately leaves. I'll stop adding edits I think I confused things enough. Again, hope this helps. |
@cwerdna19 thanks for your (VERY) detailed explaination. I'll see if I can downgrade to the version you are using. And lock it there for the time being. I looked at the code. And yes, there is a TON of outdated code and packages in there. So I'm not sure how stable it's gonna be... |
I have read what is here, I also run a Teamspeak server with my own music bot there, recently I had to update the YouTube-DL.exe file I had there and it worked fine, so it sounds to me like a YouTube situation (adblockers maybe). I am running this bare metal on Windows Sever along with my Teamspeak bot in windows services. Following cwerden's comments I have tried running "4.15.4" of ytdl-core but sadly no audio, this debug however shows the video did somewhat parse but I did not hear anything in the VC with the bot.
I also did a debug with the current environment which is below with the latest youtube core "4.15.8" and all other modules up to date:
|
Just pulled services: Tried 3 commands: /play never gonna give you up
/play https://www.youtube.com/watch?v=dQw4w9WgXcQ
Bot joined voice channel, waited few seconds and disconnected. /play https://open.spotify.com/track/4PTG3Z6ehGkBFwjybzWkR8 Distro: Debian 12.8 Debug log in attachment |
I have a completely working installation of Muse at the moment. It plays music perfectly fine from Youtube and everything I've tried doing with it so far has worked without a hitch. But I'm going to apologize for my ignorance before I go any further. I am extremely inexperienced to this level of CLI Application complexity (and this is pretty simple stuff I'm sure). Most of what's going on in this thread is way over my head. I found this bot on a whim while looking for a replacement to JMusicBot. , and it took me hours to even get the basic installation done through Docker. I couldn't even get the install command:
to work no matter what I tried. I ended up cloning the latest Muse repository and building the image locally somehow, inputting the env variables in during runtime, and it just magically worked. I'd love to help you guys troubleshoot...whatever it is that's going on... especially since I have a fully functional Muse installation as of this very moment. But I was genuinely unable to figure out how to even create an ENV file for the Docker container in the first place, much less get it to debug mode... So that's the level of novice we're working with. I glanced at the Node is either:
or:
ffmpeg is either:
or:
ytdl-core only appears once. Not sure if ytsr is of any significance but there it is.
If I can help further let me know, but don't waste more effort on me than it's worth. Sorry folks >.<. |
@WojenHere think you could try by going to the latest branch and doing the same above, or by using a different api key. |
@Codixer just tried again latest with the same above and pr-1182. Both with different new api keys. Still the same |
@Zereah Can you upload this somewhere and send a link to download? |
@WojenHere Sure thing. Haven't used a file share site in some time, hope MEGA is ok. https://mega.nz/file/U0dmzYYA#L0VLVvoHpKmMstNNDYsZCLn6AITs2zXpAXzgJhwR-sA Hope it helps out in some way. |
@Zereah |
Closes #1173
Closes #1171
Closes #1166
Closes #1165
Closes #1163