Improve badge ordering #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fails on "U/1U,U/11,U/5" for example it does not satisfy a > b && b > c => a > c |
Emilgardis
commented
Apr 22, 2023
| match self.set_id.partial_cmp(&other.set_id) { | ||
| Some(core::cmp::Ordering::Equal) => {} | ||
| // XXX: order known badges like first-party site | ||
| // FIXME: is the reflexive and transitive? as needed by Ord |
There was a problem hiding this comment.
this needs to be fixed
src/badges.rs
Outdated
| self.id.as_str().parse::<u32>(), | ||
| other.id.as_str().parse::<u32>(), | ||
| ) { | ||
| (Ok(s), Ok(other)) if s != other => s.partial_cmp(&other), |
There was a problem hiding this comment.
"01".parse() == "1".parse(), but they are not equal, this fixes that
Co-authored-by: Emil Gardström <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has some issues, but posting what I have so far.
The implementation is currently not sufficiently transitive for implementing Ord