Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix css validation logging + refactor code #297

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

lordlabuckdas
Copy link
Contributor

  • end_time being calculated in the finally part of the block guarantees that printing elapsed time will not error out due its non-initialization. This however increases the end time (though by an insignificant amount) due to cloner shutting down.
  • Improved output formatting issues with the spinner animation.
  • Cloner shows CSS validation despite it being disabled by default. This was because CSS validation was set to use the default logger. This PR makes sure that all CSS validation is sent to the logs and disables it if set to False.
  • With this PR, the presence of the --css-validate flag enables CSS validation and does not require the user to enter "true" or "false" after it.
  • itr, used as the index of the spinner animation, will now never exceed len(animation)-1

@afeena afeena merged commit 007903f into mushorg:develop Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants