Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrying of urls #298

Merged
merged 1 commit into from
Jun 29, 2021
Merged

retrying of urls #298

merged 1 commit into from
Jun 29, 2021

Conversation

lordlabuckdas
Copy link
Contributor

  • I have redesigned the new_urls queue to facilitate retrying of URLs.
  • Each item of new_urls is a tuple of a tuple and integer - ((current_url: str, level: int), try_count: int).
  • If the data is not successfully retrieved, the URL is again added to the queue with itstry_count increased by one.
  • The URL is tried for at-most 2 times before being dropped.
  • Retrying of URLs is all the more important in the case of headless cloning where there is a high chance of timeouts or connection errors.

PR is currently in draft to accommodate changes of headless cloning.

@lordlabuckdas lordlabuckdas force-pushed the retry_urls branch 2 times, most recently from 5b47118 to 8fcb559 Compare June 27, 2021 11:27
@lordlabuckdas lordlabuckdas marked this pull request as ready for review June 27, 2021 11:27
@afeena
Copy link
Collaborator

afeena commented Jun 28, 2021

@lordlabuckdas could you please resolve the conflict?

@lordlabuckdas lordlabuckdas force-pushed the retry_urls branch 2 times, most recently from b7bdaea to 0c23661 Compare June 28, 2021 15:42
@lordlabuckdas
Copy link
Contributor Author

Done 👍 @afeena

mzfr
mzfr approved these changes Jun 28, 2021
View reviewed changes
Copy link
Collaborator

@mzfr mzfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good to me 👍

@afeena afeena merged commit a2b8e3b into mushorg:develop Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzfr mzfr mzfr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordlabuckdas @afeena @mzfr