Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error templating fixes #308

Merged
merged 3 commits into from
Aug 14, 2021
Merged

error templating fixes #308

merged 3 commits into from
Aug 14, 2021

Conversation

lordlabuckdas
Copy link
Contributor

  • Snare cannot be made completely non-fingerprint-able because a malformed request triggers a 400 exception which cannot be handled by aiohttp at the moment (ref aiohttp#5358 and aiohttp#3287).
  • This PR ensures that proper headers are assigned during 404 and 500 errors.
  • HttpRequestHandler.remove_default_server_header removes the default Server header to prevent leakage of the aiohttp server banner.

@afeena afeena merged commit f6b1ba5 into mushorg:develop Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzfr mzfr mzfr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lordlabuckdas @mzfr @afeena