Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base shortcuts #517

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

max246
Copy link

@max246 max246 commented May 30, 2024

This is part of the request #1645 , it adds shortcuts to the UI

Adding the media control for:
Mute
Volume Up/Down
Play/Pause
Stop
Prev/Next track

Unfortunately you need to have the window focus to make it work since mediaSession doesnt seems to work with my integration

src/App.vue Outdated Show resolved Hide resolved
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see in-line feedback - keep the PR small and simple and focus only on the media controls. Also, you are only accounting for the happy flow now. If the api connection is not there yet or no player is active this will crash

@marcelveldt
Copy link
Member

I've just tested this PR and it was not working, especially not in the subpages.
So back to the drawing board, we might want to look into mediaSession again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants