Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapcast: Reload built-in server in case of connection loss #1442

Merged
merged 11 commits into from
Jul 4, 2024
Merged

Snapcast: Reload built-in server in case of connection loss #1442

merged 11 commits into from
Jul 4, 2024

Commits on Jul 3, 2024

  1. move builtin server logic to own methods

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    4685869 View commit details
    Browse the repository at this point in the history

  2. finish _restart_builtin_server

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    407b52f View commit details
    Browse the repository at this point in the history

  3. add return types

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cdd1ab4 View commit details
    Browse the repository at this point in the history

  4. add mising await

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3558deb View commit details
    Browse the repository at this point in the history

  5. add delay

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    39727e8 View commit details
    Browse the repository at this point in the history

  6. disable callback

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    50d43d9 View commit details
    Browse the repository at this point in the history

  7. go back

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cf8301a View commit details
    Browse the repository at this point in the history

  8. Allow network fail once

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8e38764 View commit details
    Browse the repository at this point in the history

  9. fix dummy mistake

    @SantiagoSotoC
    SantiagoSotoC committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f58dd6d View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Update music_assistant/server/providers/snapcast/__init__.py 

    Co-authored-by: Marcel van der Veldt <[email protected]>
    @SantiagoSotoC @marcelveldt
    SantiagoSotoC and marcelveldt authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4194b74 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @marcelveldt
    marcelveldt authored Jul 4, 2024
    Configuration menu
    Copy the full SHA
    432ec85 View commit details
    Browse the repository at this point in the history