-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audible audiobook provider #1842
base: dev
Are you sure you want to change the base?
Conversation
@ztripez can you provide some text for the docs? We have the following headings. You don’t need text for all of them. Please see the other providers for ideas of what to add. I could extract most of this from your opening post in the PR but I am conscious of the improvements you have made since then. Just the text is fine I will do the actual PR for the docs as a number of things need to be done. FEATURES |
updated with device registration info. FEATURES
CONFIGURATIONTo set up the Audible provider, follow these steps:
Note: If you need to re-authenticate or change the marketplace, you will have to go through the authentication process again. KNOWN ISSUES/NOTES
NOT YET SUPPORTED
Please note that this implementation has been tested with the US market, but it should work with all other markets as well. Future improvements include enhancing browsing capabilities and implementing search functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you run mypy -p music_assistant.providers.audible
you should see any typing errors just for your provider. This isn't enabled on CI yet, but will be soon.
I'm thinking that I perhaps should rename the provider from |
Are you 100% sure about the on_streamed callback ? Because I did a couple of tests today and it worked fine. So basically when playback stops or the queue transitioned to the next track you should get that callback. |
Hm that's strange, I'll take a look again. |
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
Co-authored-by: Marcel van der Veldt <[email protected]>
just a handful of small linter/typing issues (dont forget to import cast from the typing package) |
Co-authored-by: Marcel van der Veldt <[email protected]>
Initial Support for Audible
This PR introduces initial support for the Audible service. With these changes, users can:
The implementation has been tested with the US market, but it should work with all other markets as well.
Future Improvements
Known Issues
on_streamed
event is not fired, so the last position cannot be communicated to Audible at this time.