Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varuous fixes and enhancements for the Soundcloud provider #1852

Merged
merged 10 commits into from
Jan 11, 2025

Conversation

robsonke
Copy link
Contributor

Several improvements to the Soundcloud provider:

  • Type Hinting and some refactoring/cleanup
  • Updated soundcloudpy dependency
  • Added soundcloud to the packages list in mypy.ini
  • Improved performance of the sync process in a few areas

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robsonke !

@marcelveldt
Copy link
Member

just the mypy conflict needs a rebase...

@robsonke
Copy link
Contributor Author

just the mypy conflict needs a rebase...

Yes, all done now. Let me know if this is the correct way

@marcelveldt
Copy link
Member

marcelveldt commented Jan 11, 2025

Yes, all done now. Let me know if this is the correct way

One more merge conflict...
nvm: github was smart enough to reoslve it

@marcelveldt marcelveldt changed the title fix: Bumping libs and improved import/sync performance for tracks Varuous fixes and enhancements for the Soundcloud provider Jan 11, 2025
@robsonke
Copy link
Contributor Author

Haha, fun. Thanks

@marcelveldt marcelveldt merged commit e27c375 into music-assistant:dev Jan 11, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants