-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define track limit for get_playlist to avoid standard limit of 100 to… #1933
Conversation
… apply Allow for larger playlists to be synced completely
Are you sure this is required? If I look at the inline documentation here it is mentioned that it will return all the songs in a playlist when |
Hi, yes you're probably right - I'm not too experienced with Python and assumed passing "None" would be the same as not passing it at all - but that doesn't seem logical based on how the method is set up. Something I didn't realize during testing is that the interface gives contradicting information - the header says there are 150 tracks (probably what I looked at while testing the change) while the actual list below is still only showing 100 tracks |
That text "150 tracks" comes from the description - its basically freetext |
So this PR can be closed ? Its already working as it should ? |
Can you double check how many tracks this playlist has inside the YT Music web app? |
150 Tracks. I thought it might have been a matter of Auto playlists behaving differently (Super mix happens to have 100 tracks in the web app, but I was looking at My Liked music which has way more but was still only showing 100 tracks) so to confirm I created a new list with 150 tracks. Overall I guess we can close the PR and create an issue instead for further investigation. Apologies for rushing it with the PR! |
Currently when calling the get_playlist method of the YT Music API, the limit parameter is passed as "None" which causes the default limit of 100 tracks to apply. In order to load larger playlists, increasing the limit in line with other occurrences in the provider where 9999 is set as the limit.