-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new feature slurs #13
base: develop
Are you sure you want to change the base?
Conversation
New feature for adding <xml:id> to slurs
Thanks for this. Would it be possible to have some more information about what it does? Is it provided somewhere? |
@roewenstrunk @riedde Whaat is the status of this PR? Is this still to be included, or shall we close it? |
Wow, that's a very old thing. If I remember it right, the problem was that there were multiple ways to encode slurs in MEI but Verovio was only able to visualize them if they where linked usind an id. I have no idea why I commited this script because my skills in XSLT were very basic in 2016. Maybe this happend during a workshop and we transformed out data using this code and liked to share it to the community. I guess @lpugin could judge if it is still needed and useful or if Verovio does this step of resolvig by itself. |
I guess that was kind of a "byproduct" from ESS 2016? |
That's absolutely possible! |
Verovio will properly render slurs with time stamps. However, I cannot really judge if it is still useful to have this in the tooling suite or not. |
@musicEnfanthen It seems to me that it was a workaround for doing something that Verovio doesn't but does today. So from my perspective this PR could be closed |
The history of this as I remember this: SibMEI produced slurs with |
There is another script for such purposes, which might be slightly more robust, and it covers many more elements from MEI, and also allows to go back and forth between tstamps and IDs. It's located in https://github.com/Edirom/data-configuration/blob/dev/helpers/components/controlevent.linking.xsl. However, this script is supposed to be embedded in other scripts, so cannot be run directly. An example on how to use it can be found in https://github.com/Edirom/data-configuration/blob/dev/helpers/controlevent.fixer.xsl. I'm still hoping that the functionality of this will eventually end up in the MEIGarage, but not sure what the status of this is (pinging @anneferger, even though this is probably a joint thing…). But of course, this doesn't preclude the inclusion of this 2016 script… |
Thanks for pointing to that script @kepper. Would it be possible to add some lines about that to the tools page? |
ESS 2016