Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature slurs #13

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

new feature slurs #13

wants to merge 2 commits into from

Conversation

RaEnigma
Copy link

ESS 2016

@lpugin
Copy link
Member

lpugin commented Sep 30, 2016

Thanks for this. Would it be possible to have some more information about what it does? Is it provided somewhere?

@musicEnfanthen
Copy link
Member

@roewenstrunk @riedde Whaat is the status of this PR? Is this still to be included, or shall we close it?

@riedde
Copy link

riedde commented Mar 26, 2022

Wow, that's a very old thing. If I remember it right, the problem was that there were multiple ways to encode slurs in MEI but Verovio was only able to visualize them if they where linked usind an id. I have no idea why I commited this script because my skills in XSLT were very basic in 2016. Maybe this happend during a workshop and we transformed out data using this code and liked to share it to the community. I guess @lpugin could judge if it is still needed and useful or if Verovio does this step of resolvig by itself.

@musicEnfanthen
Copy link
Member

musicEnfanthen commented Mar 27, 2022

I guess that was kind of a "byproduct" from ESS 2016?

@riedde
Copy link

riedde commented Mar 27, 2022

That's absolutely possible!

@lpugin
Copy link
Member

lpugin commented Mar 28, 2022

I guess @lpugin could judge if it is still needed and useful or if Verovio does this step of resolvig by itself.

Verovio will properly render slurs with time stamps. However, I cannot really judge if it is still useful to have this in the tooling suite or not.

@riedde
Copy link

riedde commented Mar 28, 2022

@musicEnfanthen It seems to me that it was a workaround for doing something that Verovio doesn't but does today. So from my perspective this PR could be closed

@rettinghaus
Copy link
Member

rettinghaus commented Apr 20, 2022

The history of this as I remember this: SibMEI produced slurs with tstamps, Verovio at first supported this, but then switched completely to use IDs, so this was needed in 2016 and we programmed this script together in the ESS workshop, and @riedde was just the one who volunteered/was assigned to make a commit. By now, Verovio also supports slurs with tstamps again, but in order to match them to the correct notehead (in polyphonic music) this is still useful.
Maybe we could move it to a different place and add some information into the file itself, review it again and finally merge it?

@kepper
Copy link
Member

kepper commented Apr 20, 2022

There is another script for such purposes, which might be slightly more robust, and it covers many more elements from MEI, and also allows to go back and forth between tstamps and IDs. It's located in https://github.com/Edirom/data-configuration/blob/dev/helpers/components/controlevent.linking.xsl. However, this script is supposed to be embedded in other scripts, so cannot be run directly. An example on how to use it can be found in https://github.com/Edirom/data-configuration/blob/dev/helpers/controlevent.fixer.xsl. I'm still hoping that the functionality of this will eventually end up in the MEIGarage, but not sure what the status of this is (pinging @anneferger, even though this is probably a joint thing…). But of course, this doesn't preclude the inclusion of this 2016 script…

@rettinghaus
Copy link
Member

Thanks for pointing to that script @kepper. Would it be possible to add some lines about that to the tools page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants