do not duplicate fermatas on rests

[rettinghaus]

closes #89

[annplaksin]

Does someone have a test file for that?

[rettinghaus]

See here.
Only the rest at the end has an extra @fermata.

[th-we]

@rettinghaus In that case, the two fermatas are deliberately input in Sibelius:

But the Sibelius file crashes the current Sibmei for reason other than two fermatas on the same rest, so we should use that as the basis for a new test case.

[th-we]

OK, created a test file.

fermatas.sib.zip

[Edit: see next post for update]

Three systems with all the same fermatas so we can re-use the same test for all of them.

Anyone feeling like writing tests?

[th-we]

Update: More comprehensive test set:

fermatas.sib.zip

[annplaksin]

I am currently looking into the crash... and I just found that little comment: ;-)

function GenerateFermata (bobj) {
    //$module(ExportGenerators.mss)
    /* Note rests can have multiple fermatas in Sibelius,
        but this is currently not supported.
        Also, fermatas added as symbols are not yet handled.
    */

When I got rid of the crash, we will see how much of the work is done. But it might be wise to rework the fermata stuff in the future.
But I would like to wait with handling the symbol fermatas until after my planned reworking of ProcessSymbol()

[th-we]

@annplaksin I fully agree. That might lead to doing the work twice.

[annplaksin]

I solved the crash and added a test to make sure, rests have no @fermata attributes.
@rettinghaus Please see my pull request to this branch.

Everything else, like fermata symbols, should be added after reworking the symbols.

[annplaksin]

Just to mention, #162 contains the changes made here and adds fermatas as sysmbols.