This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
Update project to use Android Gradle plugin v3.x #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the project to use the latest Gradle plugin and also bumped up all the other dependencies. Also, the response builder in OkHttp 3.8 has made the message mandatory which Barricade was not passing, causing IllegalStateExceptions. I've fixed that issue by hardcoding a static message for now. In the future, we could make even the message configurable like we do for status codes.
|
Alright, it's late now and Travis refuses to behave. Will look into the build failure tomorrow. |
|
thank you! |
|
Does this help? OneBusAway/onebusaway-android@fa98297 |
|
This might be better: https://stackoverflow.com/a/28751112/3268303 |
|
@mustafa01ali i miss you |
|
Hey guys, got busy with work. Will try and work on this tonight. |
|
I spent several hours trying to fix the Travis emulator issue with no luck. A similar issue was reported to Travis back in March but they haven't bothered to look into it till now. I've disabled running instrumentation tests for now to unblock this and created #56 to find a solution for the CI issue. Note: Since these changes do not change the library API or behaviour, we will not be publishing an update to Bintray. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messagemandatory which Barricade was not passing, causing IllegalStateExceptions. I've fixed that issue by hardcoding a static message for now. In the future, we could make even the message configurable like we do for status codes.Fixes #54