Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure the parameter is not nil before passing it to [NSURL fileURLWi… #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −6
Open

ensure the parameter is not nil before passing it to [NSURL fileURLWi… #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions Source/MMWormholeCoordinatedFileTransiting.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,15 @@ - (BOOL)writeMessageObject:(id<NSCoding>)messageObject forIdentifier:(NSString *
if (messageObject) {
NSData *data = [NSKeyedArchiver archivedDataWithRootObject:messageObject];
NSString *filePath = [self filePathForIdentifier:identifier];
NSURL *fileURL = [NSURL fileURLWithPath:filePath];

if (data == nil || filePath == nil || fileURL == nil) {
if (data == nil || filePath == nil) {
return NO;
}

//filePath can not be nil, otherwise will crash.
NSURL *fileURL = [NSURL fileURLWithPath:filePath];
if (fileURL == nil) {
return NO;
}
NSFileCoordinator *fileCoordinator = [[NSFileCoordinator alloc] initWithFilePresenter:nil];
NSError *error = nil;
__block BOOL success = NO;
Expand Down Expand Up @@ -71,12 +74,14 @@ - (BOOL)writeMessageObject:(id<NSCoding>)messageObject forIdentifier:(NSString *
}

NSString *filePath = [self filePathForIdentifier:identifier];
NSURL *fileURL = [NSURL fileURLWithPath:filePath];

if (filePath == nil || fileURL == nil) {
if (filePath == nil) {
return nil;
}

NSURL *fileURL = [NSURL fileURLWithPath:filePath];
if (fileURL == nil) {
return nil;
}
NSFileCoordinator *fileCoordinator = [[NSFileCoordinator alloc] initWithFilePresenter:nil];
NSError *error = nil;
__block NSData *data = nil;
Expand Down