feat!: Fetch full-size source image for accurate aspect ratio #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
reviewed
Dec 13, 2024
luwes
reviewed
Dec 13, 2024
luwes
reviewed
Dec 13, 2024
|
@luwes comments addressed, thanks for the feedback! |
luwes
changed the title
luwes
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: returned props
widthandheightnow return the original unresized thumbnail dimensions from Mux.closes #3
This PR fetches the full-size image from Mux and measures it for
width,height, andaspectRatioThis is a potentially breaking change; authors who expect small widths and heights <= 16 may be surprised. I considered making this an additive change, with new
sourceWidth,sourceHeight, andsourceAspectRatioreturn values, but considering 1) the v0.x.x versioning and 2) the original intent of the width, height, and aspectRatio values, I consider this to be the right move.This PR also makes an unrelated change:
Previously, this library would fetch the full-size image if
quality < 1. Now, it errors ifquality <= 0, which I believe might've been the original intent of that line.Looking forward to hearing what you think!