fix: hide error dialog on playback recovery #1065
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
==========================================
- Coverage 78.55% 77.51% -1.05%
==========================================
Files 59 51 -8
Lines 11080 12335 +1255
Branches 0 726 +726
==========================================
+ Hits 8704 9561 +857
- Misses 2376 2746 +370
- Partials 0 28 +28 ☔ View full report in Codecov by Sentry. |
heff
approved these changes
Feb 2, 2025
| @@ -2,6 +2,10 @@ import { TextTrackKinds, TextTrackModes } from '../constants.js'; | |||
| import { getTextTracksList, updateTracksModeTo } from '../utils/captions.js'; | |||
| import { TextTrackLike } from '../utils/TextTrackLike.js'; | |||
|
|
|||
| export const isMediaPlaying = (media) => { | |||
| return !media.paused && !media.ended && media.readyState > 2; | |||
There was a problem hiding this comment.
Do we need this? None of these should ever be false when the playing event is fired.
|
For |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change hides the error dialog when playback recovers (playing event fires and media state indicates playing).