Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pip-unsupported-apple-pwa): Detect Apple+Safari+PWA for no PiP su… #781

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

cjpillsbury
Copy link
Collaborator

@cjpillsbury cjpillsbury commented Dec 7, 2023

…pport. Add PWA example.

To Test

@cjpillsbury cjpillsbury requested review from heff and a team as code owners December 7, 2023 17:25
Copy link

vercel bot commented Dec 7, 2023

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 9:19pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 9:19pm

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a04fa23) 78.59% compared to head (6811416) 78.57%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/js/utils/server-safe-globals.js 57.14% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
- Coverage   78.59%   78.57%   -0.02%     
==========================================
  Files          59       59              
  Lines       11046    11069      +23     
==========================================
+ Hits         8682     8698      +16     
- Misses       2364     2371       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! LGTM. tested on iOS and Mac Chrome

@cjpillsbury cjpillsbury merged commit e17c11e into muxinc:main Feb 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants