Added event dispatch for youtube errors #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
R-Delfino95
approved these changes
Feb 11, 2025
|
LGTM! |
luwes
reviewed
Feb 14, 2025
| onError: (error) => console.error(error), | ||
| onError: (error) => { | ||
| console.error(error); | ||
| this.dispatchEvent(new CustomEvent('error', { detail: error })); |
There was a problem hiding this comment.
I know this can be handy but the native video API doesn't pass any data with the event. I think we should stay 1:1 as much as possible so a new Event('error') and then store the last error in a variable and return it in a get error() property
luwes
requested changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Added
dispatchEvent()call to the errors for YouTubeaddEventListener('error')to display it in the console in the YouTube video elementThe following screenshot displays how, given an issue with the YouTube video, the console will display the error with all the information
