Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process to follow for updating PHP OAS templates with upstream:
gen/package.json
andgen/openapitools.json
with new generator versionsyarn install
cd ./gen && make template-diff
mv ./tmp/template-changes.diff ./template-changes.diff
patch -s -p0 < template-changes.diff
git add -p ./gen/templates
generator-config.json
values. Valid values can be seen by runningopenapi-generator config-help -g php
Templates
These will get pulled in automatically when you run
make template-diff
in step 3 above. They'll be saved ingen/tmp/oas-base-templates
. However, they're available for manual inspection/git blame/sanity check here: https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/phpTesting
yarn && yarn validate:full
)OAS_SPEC_PATH=~/path/to/openapi-specification/dist/spec.json make -C ./gen build
MUX_TOKEN_ID=xxxxxMUX_TOKEN_SECRET=xxxxx ./test.sh
Notes:
Fixes
#45
#54