-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more better logging #1
Conversation
WalkthroughThe recent updates to the Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
aiohuesyncbox/errors.py
Outdated
@@ -36,4 +40,5 @@ class InvalidState(AiohuesyncboxException): | |||
|
|||
def raise_error(code: int, message: str) -> None: | |||
cls = ERRORS.get(code, AiohuesyncboxException) | |||
logger.debug("raise_error, %s, %s, %s" % (code, message, cls)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using f-strings for better readability and performance in logging statements.
- logger.debug("raise_error, %s, %s, %s" % (code, message, cls))
+ logger.debug(f"raise_error, {code}, {message}, {cls}")
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
logger.debug("raise_error, %s, %s, %s" % (code, message, cls)) | |
logger.debug(f"raise_error, {code}, {message}, {cls}") |
Summary by CodeRabbit