Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CIs on pull requests #101

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Enable CIs on pull requests #101

merged 1 commit into from
Jan 4, 2024

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Jan 3, 2024

closes #100

@mverleg
Copy link
Owner

mverleg commented Jan 4, 2024

I think I've disabled those as a default because it's not always safe to run Actions on not-yet-approved code, since they have access to secrets etc. But this repository actually doesn't seem to have such secrets, so it's probably fine. Thanks for the change!

@mverleg mverleg merged commit b9bf565 into mverleg:master Jan 4, 2024
30 checks passed
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 4, 2024

I think that secrets are typically only enabled for PRs that come from "protected" branches and such.

COntributors would fork, and typically won't have access to the secrets.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 4, 2024

this was my understanding on how many of these CI pipelines were structures from different providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIs
2 participants