Skip to content

Commit

Permalink
devices: add todos to ensure the open questions get done
Browse files Browse the repository at this point in the history
  • Loading branch information
mvo5 committed Aug 26, 2024
1 parent 5ab30a3 commit ae74304
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion devices/org.osbuild.lvm2.lv
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ class LVService(devices.DeviceService):

return major, minor

def open(self, devpath: str, parent: str, tree: str, options: Dict):
def open(self, devpath: str, parent: str, tree: str, options: Dict) -> None:
lv = options["volume"]

assert not parent.startswith("/")
Expand All @@ -186,6 +186,9 @@ class LVService(devices.DeviceService):

# Find the volume group that belongs to the device specified
# via `parent`
# XXX: does parent_path already needs changing above for
# manage_devices_files?
# XXX2: add test
part = options.get("vg_partition")
if part:
parent_path += f"p{part}"
Expand Down

0 comments on commit ae74304

Please sign in to comment.