chore(deps): update rules_cc to 0.1.1 #113
Conversation
Signed-off-by: wep21 <[email protected]>
|
need to update |
|
@mvukov Could you update your forked branch for ros_comm used here to a more recent version (maybe even the latest 1.17) It should at least contain ros/ros_comm@5f13bb3 which fixes the |
MODULE.bazel
Outdated
| @@ -23,7 +23,7 @@ bazel_dep(name = "glog", version = "0.7.1") | |||
| bazel_dep(name = "googletest", version = "1.15.2") | |||
| bazel_dep(name = "lz4", version = "1.9.4") | |||
| bazel_dep(name = "platforms", version = "0.0.10") | |||
| bazel_dep(name = "rules_cc", version = "0.1.0") | |||
| bazel_dep(name = "rules_cc", version = "0.0.17") | |||
There was a problem hiding this comment.
This seems relevant for this PR, other changes should be in a separate PR.
There was a problem hiding this comment.
The other changes are required to this pass. If you want this change as a single commit, we would have to bump all boost first in a seperate PR.
The boost bumps contain the fixes after 0.1.0 was yanked.
There was a problem hiding this comment.
Merging #114 first, should help to get the rules_cc bump exclusively.
There was a problem hiding this comment.
I just now see that this is a downgrade. Why do we need to downgrade?
There was a problem hiding this comment.
0.1.0 was yanked on BCR. But a few days ago 0.1.1 was released so upgrading to 0.1.1 is also possible.
|
@wep21 could you update the PR please. The boost bumps are already merged. |
|
@hofbi updated |
wep21
changed the title
#112 with updating boost