[Launch] Pass along data to launch py_binary #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvukov
reviewed
Aug 24, 2024
mvukov
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cases of having launch files that include other launch files or launch file that read a params.yaml (via the tag) the py_binary seems to need access to these files at runtime. I tried making it a data dependency but bazel reported an error.
Traced it down to data being both in kwargs and passed in locally. Would like to check this in to enable others to also make full use of the launch file syntax
Don't think we need the same pattern for deps because deps will only ever be whatever is demanded by the
launch.py.tplfile